Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cache sources too #1226

Merged
merged 16 commits into from
Dec 4, 2024
Merged

feat: cache sources too #1226

merged 16 commits into from
Dec 4, 2024

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Nov 29, 2024

This PR enables the caching of the source folder, too.

This meant we had to change the behavior a bit:

  • cache has to be restored to the exact same prefix. That means every output will build in the same directory (should also fix the Windows bug!). For this, we currently use the name of the first output (we don't have the recipe.name available, but that could be fixed).
  • When the cache is involved, we don't fetch sources for the outputs. We should, however, change this to fetch the "diff" of the sources. Sources that were already fetched for the cache should not be re-fetched, but additional sources should be added on top (user has to make sure that there is no clobbering. Cache has its own source section now.

These changes made the example at https://github.com/wolfv/rattler-build-cache-test work :)

  • fix finalized sources in output (not correct right now I think)

@wolfv
Copy link
Member Author

wolfv commented Nov 29, 2024

OK, I had a sort-of rethink a little bit and now I think that the cache should have it's own source section so that things are neatly separated.

@wolfv
Copy link
Member Author

wolfv commented Nov 30, 2024

Added a PR for the schema: prefix-dev/recipe-format#45

@wolfv wolfv merged commit 5f0a3e5 into prefix-dev:main Dec 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant