-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cache sources too #1226
Merged
Merged
feat: cache sources too #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OK, I had a sort-of rethink a little bit and now I think that the cache should have it's own |
Added a PR for the schema: prefix-dev/recipe-format#45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the caching of the source folder, too.
This meant we had to change the behavior a bit:
recipe.name
available, but that could be fixed).When the cache is involved, we don't fetch sources for the outputs. We should, however, change this to fetch the "diff" of the sources. Sources that were already fetched for the cache should not be re-fetched, but additional sources should be added on top (user has to make sure that there is no clobbering.Cache has its own source section now.These changes made the example at https://github.com/wolfv/rattler-build-cache-test work :)