Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: canonicalize the output directory before checks #738

Merged
merged 5 commits into from
Oct 11, 2024
Merged

fix: canonicalize the output directory before checks #738

merged 5 commits into from
Oct 11, 2024

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Mar 27, 2024

fixes #713

@orhun
Copy link
Contributor Author

orhun commented Mar 29, 2024

Not sure why the test fails on macOS :/

@orhun
Copy link
Contributor Author

orhun commented Apr 2, 2024

macOS CI can't find pytest for some reason

 pixi run end_to_end_test
✨ Pixi task (default): pytest test/end-to-end -v -s
Error launching 'pytest': No such file or directory (os error 2)

Not sure how that's related to the changes in this PR.

@chawyehsu
Copy link
Contributor

So what is blocking this? I don't see macOS CI fails on it.

@wolfv wolfv merged commit e50dc78 into prefix-dev:main Oct 11, 2024
15 checks passed
wolfv pushed a commit to wolfv/rattler-build that referenced this pull request Nov 6, 2024
@orhun @wolfv
fix: canonicalize the output directory before checks (prefix-dev#738)
eabd89c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rattler-build should fail if the output directory is part of the recipe dir
3 participants
@orhun @chawyehsu @wolfv