Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation of virual env and installing of wheel files into this env. #78

Closed
4 tasks done
Tracked by #32
tdejager opened this issue Nov 16, 2023 · 3 comments
Closed
4 tasks done
Tracked by #32
Assignees
Labels
enhancement New feature or request

Comments

@tdejager
Copy link
Contributor

tdejager commented Nov 16, 2023

We need this mainly because of #32.

When we are building sdist we need create a build environment isolated from the system but using the current system interpreter so that we can build the source dist in this environment.

I'm already working on this in https://github.com/tdejager/rip/tree/feat/venv-creation. In which I'm planning to:

Currently, I want to do this with just with python -m venv but if we have the system intepreter we can create an environment without executing python if we want later on see: https://packaging.python.org/en/latest/specifications/virtual-environments/#declaring-installation-environments-as-python-virtual-environments.

Edit:

Currently ticking this off in: #82

@cnpryer
Copy link

cnpryer commented Nov 20, 2023

Create a small test that executes a python thing in there

Have you thought about how you'd want to test something like this?

@tdejager
Copy link
Contributor Author

Create a small test that executes a python thing in there

Have you thought about how you'd want to test something like this?

I actually have a simple test in this PR: #82

baszalmstra pushed a commit that referenced this issue Nov 20, 2023
This is the first iteration in rip to add support for #78.

Small test was added to see if the wheel install works, this will mainly
be used for #32 but we can also integrate this into the `rip` binary to
be able to add the install path there as well. @baszalmstra let me know
if you want me to add this in a separate PR once this is merged.
@tdejager
Copy link
Contributor Author

Closing this we can re-open if we need more specific functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants