fix: allow wildcards in ambiguos specifiers #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes metadata contains specifiers like `>=3.5.*`. This is ambiguous because it either means `3.5.*` or `>=3.5`. The former is more restrictive than the latter but most likely one means the latter. This PR adds a boolean that allows a user to specify whether this should result in an error or whether the least restrictive bound should be chosen. With this PR the resolver chooses the least restrictive bound.
wolfv
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes metadata contains specifiers like
>=3.5.*. This is ambiguous because it either means3.5.*or>=3.5. The former is more restrictive than the latter but most likely one means the latter. This PR adds a boolean that allows a user to specify whether this should result in an error or whether the least restrictive bound should be chosen. With this PR the resolver chooses the least restrictive bound.Fix #38