Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comments: Sign in not working #81

Closed
nsosio opened this issue Oct 9, 2023 · 1 comment · Fixed by #82
Closed

comments: Sign in not working #81

nsosio opened this issue Oct 9, 2023 · 1 comment · Fixed by #82
Assignees
@casperdcl
Labels
bug framework & docs meta-content

Comments

@nsosio
Copy link
Contributor

nsosio commented Oct 9, 2023

When signing in with GitHub to add a comment in a chapter I've got 404.

image
@nsosio nsosio added the bug label Oct 9, 2023
@casperdcl
Copy link
Contributor

this is caused by https://utteranc.es redirecting to /chapter.html (rather than /chapter/ or /chapter/index.html).

Based on utterance/utterances#474 this is due to jupyter-book build --builder dirhtml generating:

<link rel="canonical" href=".../chapter.html" />

instead of:

<link rel="canonical" href=".../chapter/" />

just reported in jupyter-book/jupyter-book#2066

@casperdcl casperdcl self-assigned this Oct 9, 2023
@casperdcl casperdcl added the framework & docs meta-content label Oct 9, 2023
casperdcl added a commit that referenced this issue Oct 9, 2023
@casperdcl
fix comments
02d50f4 
- work-around for jupyter-book/jupyter-book#2066
- fixes #81
@casperdcl casperdcl mentioned this issue Oct 9, 2023
Merged
casperdcl added a commit that referenced this issue Oct 9, 2023
@casperdcl
fix comments
1b168b4 
- work-around for jupyter-book/jupyter-book#2066
- fixes #81
casperdcl added a commit that referenced this issue Oct 9, 2023
@casperdcl
fix comments
eba00e7 
- work-around for jupyter-book/jupyter-book#2066
- fixes #81
@casperdcl casperdcl mentioned this issue Oct 9, 2023
Closed
41 tasks
@casperdcl casperdcl changed the title Github Sign in comments: Sign in not working Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casperdcl casperdcl

Labels
bug framework & docs meta-content
Projects
No open projects
Prem ML
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix comments premAI-io/state-of-open-source-ai
2 participants
@nsosio @casperdcl