Clear additional global state between unit test runs #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clears out some global state that was being left over between unit tests runs, causing indeterminate results when running multiple tests against data at the global scope.
|
|
|
The macOS test failed because of one other 'order' dependency... so this commit is a step in the right direction, but I think there is some other global state that has a somewhat rare effect on that particular macOS test. either way... LGTM... merge it... |
starkos
added a commit
that referenced
this pull request
Apr 2, 2018
Follow up to #1021: I removed the state blocks added by the tests, but neglected to put back a new, empty global state block for the next run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clears out some global state that was being left over between unit tests runs, causing indeterminate results when running multiple tests against data at the global scope.