-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Objective-C and Objective-C++ in xcode and gmake2 #1086
Conversation
55eba61
to
10658a7
Compare
I remember seeing this language file config back when I was making compileas work (.c compiled as .cpp). I dismissed it as stale since I did not find any other references to 'language' as a file configuration parameter outside the xcode module and figured it was leftover cruft from the transition from premake-xcode to premake-core. This seems like it is doing the same kind of deal as my PR, just with .cpp compiled as .mm. Is 'language' the preferred keyword (over 'compileas') for doing this kind of configuration? I am only asking in case I need to update my PR, which I will happily do. |
I'm more than happy to change it to use |
@samsinsane I would say that compileas is redundant (maybe it should be just an alias for language?) Ideally we shouldn't have two ways of doing the same thing as it's confusing. |
There's been a few other discussions around I'm not sure when I'll get a chance to update this PR, but if there aren't any objections to using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we were waiting for some follow-up changes on this one; @samsinsane any interest in finishing this one up? I agree that compileras()
is a better way forward than language()
.
@starkos unfortunately I won't be able to test it properly as I don't get a chance to work on a Mac very often. It might be better for someone else to pick it up? Or I can pick it back up when I get a chance to work on a Mac again. |
We are getting our macs here refreshed so I may be able to test this out |
@samsinsane - How would you like to proceed with this? I'm inclined to rebase it and merge as is, but I'm not set up to test the resulting builds. What say you? If you're against merging it, I'd like to close it as stale. It is linked to the related issues so it wouldn't be hard to resurrect if someone finds the need. |
- Added unit tests for Objective-C and Objective-C++
10658a7
to
a4bba42
Compare
@starkos I updated the PR to use |
I'm working up to a new release. Since we can't test this thoroughly ourselves let's hold off until the release branch is cut, and then I'll approve it. |
Changed my mind; there will time enough to review before the release actually gets cut. Merged. |
Objective-C
andObjective-C++