Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix targetextension in xcode4 #1143

Merged
merged 2 commits into from
Jul 31, 2018
Merged

Fix targetextension in xcode4 #1143

merged 2 commits into from
Jul 31, 2018

Conversation

tempura-sukiyaki
Copy link
Contributor

Add support for ConsoleApp.

@tempura-sukiyaki
Fix targetextension in xcode4
b89eef5 
Add support for ConsoleApp.
samsinsane
samsinsane requested changes Jul 31, 2018
View reviewed changes
Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some unit tests for this?

@samsinsane
Copy link
Member

Thanks!

@samsinsane samsinsane merged commit 7f92793 into premake:master Jul 31, 2018
@tempura-sukiyaki tempura-sukiyaki deleted the xcode4-consoleapp-targetextension branch July 31, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsinsane samsinsane samsinsane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tempura-sukiyaki @samsinsane