Add tests for xcode id generator #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsinsane
approved these changes
Nov 13, 2018
|
Yeah, I have been making local tests here for some of the custom modifications we have made to premake (nothing major, most of which ends up as pull requests). Had to figure out why the windows executable would create an xcode project differently than when we ran the same scripts on the macs. Eventually nailed it down to the size differences of 'long' between the 32 and 64-bit versions of the executable. So right now I believe we are able to generate the exact same output from all the major platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the 'long' type is not always of size four bytes - which is what the current code assumes. Changed to uint32_t and added tests for the xcode id-generator.