Skip to content

Allow using Clang 5.0 for VSAndroid projects #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Allow using Clang 5.0 for VSAndroid projects #1223

wants to merge 3 commits into from

Conversation

ifarbod
Copy link
Contributor

@ifarbod ifarbod commented Jan 11, 2019 •
edited
Loading

This is only supported in VS2017+, should I add a check for it or is it ok like this?

PS: Can the androidproj value for kind be renamed to something else? Maybe something like AndroidApp, Packaging, or Application? It doesn't really feel inline with WindowedApp and other values.

@ifarbod
Copy link
Contributor Author

ifarbod commented Jan 22, 2019

Looks like #1112 already includes this.

@ifarbod ifarbod closed this Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ifarbod