Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the README #1325

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Improve the README #1325

merged 1 commit into from
Aug 27, 2019

Conversation

starkos
Copy link
Member

@starkos starkos commented Aug 21, 2019

samsinsane
samsinsane requested changes Aug 22, 2019
View reviewed changes
Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub seems to be broken for me today and half the review functionality doesn't work - line 75 of the readme says our twice in the last sentence. Otherwise LGTM 👍

@starkos
Copy link
Member Author

starkos commented Aug 23, 2019

Thanks for catching that, I'll get it fixed.

@starkos starkos merged commit 64af84d into premake:master Aug 27, 2019
@starkos starkos deleted the update-readme branch August 27, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsinsane samsinsane samsinsane requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@starkos @samsinsane