Account for filename collisions on systems with case-insensitive file… #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratzlaff
force-pushed
the
fix_case_insensitive_collisions
branch
from
f7259c7 to
5142230
Compare
samsinsane
approved these changes
Sep 12, 2019
ratzlaff
added a commit
to ratzlaff/premake-core
that referenced
this pull request
Sep 13, 2019
|
Apologies if this gets asked a lot, but is a new pre-release expected that contains this fix? I just ran into this exact problem myself on the latest pre-release version. No worries if a pre-release is not in sight, I can build it myself as well! 👍 Just wanted to give a ping that someone randomly hit into this issue.. 😅 |
|
Top of my Premake to-do list right now. I had planning to punch through some PRs and low-hanging issues and get the release out when I got back the States a few weeks ago, but as everything has gone sort of…sideways since then I haven't been able to make the progress I'd hoped. If I continues to drag on I'll abandon the fixes and just make the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Continues the work done in PR #1191 by accounting for case-insensitive filesystems
How does this PR change Premake's behavior?
when computing sequence numbers for a compiled object filename, use the lowercase version of the base file name
closes #1241