Fix systemversion("latest") on VS2017 #1424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
My take on a cleaned-up version of #1317. Implements the workaround described here to enable VS 2017 to discover the correct version of the Windows 10 SDK.
h/t to @jeaiii to discovering the fix, and putting together the original PR.
How does this PR change Premake's behavior?
Should not be any breaking changes. Does add this markup to every VS 2017 project, regardless of whether
systemversion("latest")
is used or not:The alternative is to scan through all of the project configurations to see if the value has been set or not before writing, but the markup is ignored if not used, and querying all of the configurations can be relatively expensive. If no one complains, this is a more efficient approach.
Anything else we should know?
No.
Did you check all the boxes?
You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!