-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for .swift file for xcode #1477
Add support for .swift file for xcode #1477
Conversation
Add support for setting swiftversion
This looks like a nice feature addition, thanks for taking the time! Unfortunately, it looks like you've broken some of the existing unit tests with your changes—we need all tests to be passing before we can merge your change. It might make things easier if you split your changes up into two PRs: one that adds Swift support, and another for the single value fix. The Swift changes should pass the existing tests with no trouble, but you will probably need to fix up some of them in order to pass your single value changes. It would also be helpful if you could add a new test or two to cover your improvements, verify they work, and protect against any future regressions. And a small GitHub tip: If you put "Closes #667" instead of "There was already an issue about this: #667" that issue will get closed automatically as soon as your PR merges. You can push new commits to this branch to patch things up, or close this one and open new one(s). Seem reasonable? |
Thanks Just one question. Do you know why the single value code was commented? |
Sorry, no! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have unit tests for the new file format and API.
What does this PR do?
swiftversion
to be able to configure Swift Language VersionHow does this PR change Premake's behavior?
.swift
on the file extension lists with proper valuesAre there any breaking changes? Will any existing behavior change?
Anything else we should know?
Add any other context about your changes here.
Did you check all the boxes?
closes #XXXX
in comment to auto-close issue when PR is merged)