Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added COPYFILE and COPYDIR tokens #1528

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

samsinsane
Copy link
Member

What does this PR do?

Adds new tokens, {COPYFILE} and {COPYDIR} to resolve issues with XCOPY being unable to copy a file.

How does this PR change Premake's behavior?

No, this does not replace or remove the existing and broken {COPY} token.

Anything else we should know?

This most likely will need more work to be done for all the edge cases where COPY differs to cp and XCOPY differs to cp. See #1232 for examples of differences with folder copying.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Copy link
Member

@starkos starkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, wish I'd gone this route in the first place. Do you think it's worth deprecating COPY?

@samsinsane
Copy link
Member Author

@starkos Perhaps, but might be worth having #1232 resolved before doing so?

@samsinsane samsinsane merged commit e557087 into premake:master Oct 2, 2020
@samsinsane samsinsane deleted the ssurtees/tokens branch October 2, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants