Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework website home & download pages #1602

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

starkos
Copy link
Member

@starkos starkos commented Mar 23, 2021

What does this PR do?

Reworks the placeholder home and download pages on the new Docusaurus-based website.

How does this PR change Premake's behavior?

No changes to Premake itself.

Anything else we should know?

I still need to rework the header and footer, and move some content from docs/ to pages/ such as the help and "who uses" pages. Tracking the work on #1547.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Copy link
Member

@KyrietS KyrietS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to rework the header and footer, and move some content from docs/ to pages/ such as the help and "who uses" pages.

Just a reminder that you can create simple pages in Markdown. Docusaurus will take care of it. You don't have to use JS and React in every page.

website/src/pages/download.js Outdated Show resolved Hide resolved
website/src/pages/download.js Outdated Show resolved Hide resolved
website/src/pages/download.js Outdated Show resolved Hide resolved
website/src/pages/index.js Outdated Show resolved Hide resolved
@starkos starkos force-pushed the website-landing-pages branch from 6e41392 to 7bae491 Compare March 24, 2021 14:42
@starkos
Copy link
Member Author

starkos commented Mar 24, 2021

Good feedback, thanks! I was going back and forth on the layout of the download links and didn't clean things up properly; I've switched them to <ul> as suggested. I'm hoping/intending to loop back and associate icons with each one at some point (why I wrapped them in <div>).

Console errors are gone. I also backed out my formatting change to docusaurus.config.js to avoid conflicts with your commit.

Copy link
Member

@KyrietS KyrietS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes you've made. It looks great now. Those DownloadLink lists still can be simplified and refactored but it's good enough to merge this commit in my opinion.

And I wouldn't worry about conflicts in docusaurus.config.js. I can always do rebase and force-push to my branch :-)

@starkos starkos merged commit e2f97cb into premake:master Mar 25, 2021
@starkos starkos deleted the website-landing-pages branch March 25, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants