xcode4: Fix missing link of sibling project with custom targetextension #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsinsane
previously requested changes
Jun 23, 2021
noresources
force-pushed
the
fix-xcode-sibling-targetextension-links
branch
from
2cd7cf6 to
3751d15
Compare
|
Code updated with early return and a single-line "if" |
starkos
approved these changes
Jun 25, 2021
noresources
force-pushed
the
fix-xcode-sibling-targetextension-links
branch
from
3751d15 to
4c58958
Compare
When a node category cannot be determined by extension, use the configuration kind when available. Add unit test to illustrate the case.
noresources
force-pushed
the
fix-xcode-sibling-targetextension-links
branch
from
4c58958 to
1ce82af
Compare
Branch was rebased (twice) without issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a node category cannot be determined by extension,
use the configuration kind when available.
Add unit test to illustrate the case.
What does this PR do?
Project with a custom targetextension were not linked to other projects
because the strategy used to determine Xocde node type was uniquely based
on node name extension.
This patch adds a "last chance" fallback based on attached configuration kind
How does this PR change Premake's behavior?
Fix a edge case bug. Should not change the behavior for most common cases.
Anything else we should know?
I kept the previous behavior as the main strategy to avoid breaking changes.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)