Update shadermodel.md #1843
Update shadermodel.md #1843
Conversation
website/docs/shadermodel.md
Outdated
|
|
||
| ```lua | ||
| shadermodel (value) | ||
| shadermodel "value" |
There was a problem hiding this comment.
Let's use shadermodel ("value") to keep consistent with other docs - (e.g.) https://premake.github.io/docs/objdir/
There was a problem hiding this comment.
I'll make the relevant changes as requested. Hey no problem, I've never been good at documentation but just wanted to make these small fixes to make things a little more clear for the future.
There was a problem hiding this comment.
Appreciate all help with docs. When you get those changes out, I'll rereview and merge them so we can get it out.
There was a problem hiding this comment.
Just poking this for line 39 as well.
|
Is there an example of this shader stuff anywhere? And does it only support HLSL? |
|
Yes it only supports HLSL. There is an example usage included in this change. |
|
@nickclark2016 Could you please approve this PR? |
|
Just saw the message, the last several weeks have been hectic for me. Still waiting on you to address that last comment, then I'll go ahead and merge. |
Changed shadermodel parameter format. Changed example syntax.
|
@KyrietS Addressed the final issue for line 39. |
|
Let's wait for @nickclark2016's approval |
What does this PR do?
Update shadermodel documentation to replace auto-generated text.
Thanks for the contribution! Please provide a concise description of the problem this request solves.
How does this PR change Premake's behavior?
Modifies the Premake documentation.
Are there any breaking changes? Will any existing behavior change?
No.
Anything else we should know?
No.
Add any other context about your changes here.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!