Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated LICENSE.txt copyright year #1851

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

nickclark2016
Copy link
Member

What does this PR do?

Updates copyright year in LICENSE.txt from 2019 to 2022.

How does this PR change Premake's behavior?

No code changes.

Anything else we should know?

Closes #1833

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@nickclark2016 nickclark2016 requested a review from starkos April 4, 2022 11:48
@nickclark2016
Copy link
Member Author

nickclark2016 commented Apr 4, 2022

Just a thought, but moving forward, why don't we add an item to the checklist where if we touch a file, we update the copyright year? That's a practice that I do where I work, and it works out better than fixing it all at once before a SW delivery.

@KyrietS
Copy link
Member

KyrietS commented Apr 4, 2022

Just a thought, but moving forward, why don't we add an item to the checklist where if we touch a file, we update the copyright year? That's a practice that I do where I work, and it works out better than fixing it all at once before a SW delivery.

I'm not a big fan of having copyright clause in every single source file but your idea is not bad. However, I think the process of checking whether someone has updated the copyright date in the file that was touched could be somehow automated (and added to the pipeline).

@nickclark2016 nickclark2016 merged commit e0de83c into premake:master Apr 5, 2022
@nickclark2016
Copy link
Member Author

Just a thought, but moving forward, why don't we add an item to the checklist where if we touch a file, we update the copyright year? That's a practice that I do where I work, and it works out better than fixing it all at once before a SW delivery.

I'm not a big fan of having copyright clause in every single source file but your idea is not bad. However, I think the process of checking whether someone has updated the copyright date in the file that was touched could be somehow automated (and added to the pipeline).

Definitely could be added to the pipeline, I'm just not 100% sure how to do it. Couldn't find a GitHub CI action in a cursory search. Maybe a simple python or bash script to check in it's own runner and fail out if the copyright of the file touched wasn't updated?

@nickclark2016 nickclark2016 deleted the copyright-to-2022 branch April 5, 2022 12:27
@KyrietS
Copy link
Member

KyrietS commented Apr 5, 2022

I don't know how to do it either. I was just thinking 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copyright year
2 participants