Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitize { "Address" } should set link flags too for gcc/clang. #2027

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Jan 26, 2023

What does this PR do?

sanitize { "Address" } set also ldflags for gcc/clang

How does this PR change Premake's behavior?

Fix generator using ldflags for gcc/clang for that option.

Anything else we should know?

Tested with my testing repo
in particular that git-action

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

@nickclark2016 nickclark2016 merged commit dd314ce into premake:master Jan 30, 2023
@Jarod42 Jarod42 deleted the gcc_sanitize_address branch January 30, 2023 13:32
@alex-rass-88
Copy link
Contributor

alex-rass-88 commented Feb 1, 2023

Hi. Address sanitizer flag also need in cflags fo C language.

Edit: It may be added to shared section

@Jarod42
Copy link
Contributor Author

Jarod42 commented Feb 8, 2023

@alex-rass-88 : Could you open an issue to extend support of sanitize { "Address" } to C-language. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants