Add some missing flags for msc toolset #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add some missing flags (compileas/c(pp)dialect). - Fix option dependency (D9007: '/external:I' requires '/external:W'). - Fix toolset version comparison (`"msc-v142" < "msc-v80"`!) (so vs2005/vs2008).
redorav
reviewed
Jul 1, 2023
| @@ -158,6 +192,12 @@ | |||
| -- | |||
|
|
|||
| msc.cxxflags = { | |||
| cppdialect = { | |||
| ["C++14"] = "/std:c++14", | |||
There was a problem hiding this comment.
How does the cppdialect keyword work currently in VS? I use it in my projects and it seems to work properly. Some other codepath?
There was a problem hiding this comment.
vs20XX generator handle flags internally.
msc.lua is not used from vs20XX generators.
msc.lua is used for Codelite/Code::Blocks/Ninja (gmakeX doesn't support it) generator with msc toolset.
nickclark2016
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For msc toolset:
"msc-v142" < "msc-v80"!) (so vs2005/vs2008) (for external warnings).How does this PR change Premake's behavior?
Just change msc toolset,
so indirectly affects Codelite (and extern modules such as Code::Blocks, ninja) when using that toolset
Anything else we should know?
One of the fix needed to make ninja works with msvc in my testing repository
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)