Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Library to available shadertypes #2217

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

vkaytsanov
Copy link
Contributor

@vkaytsanov vkaytsanov commented Jun 11, 2024

What does this PR do?

Adds a Library shadertype to the options when having hlsl shaders in the project

How does this PR change Premake's behavior?

It doesn't

Anything else we should know?

Nothing

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Copy link
Contributor

@Jarod42 Jarod42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- website\docs\shadertype.md should be updated (doc)

@vkaytsanov vkaytsanov requested a review from Jarod42 June 15, 2024 20:12
@Jarod42
Copy link
Contributor

Jarod42 commented Aug 7, 2024

Asked on stackoverflow.com

@samsinsane samsinsane merged commit 62b442b into premake:master Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants