Add tests for table.merge.
#2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarod42
reviewed
Sep 26, 2024
tritao
force-pushed
the
fix-table-merge
branch
from
5884321 to
25dd5fd
Compare
tritao
changed the title
table.merge for array-based tables.table.merge.
tritao
force-pushed
the
fix-table-merge
branch
from
3de40f9 to
4a76aa8
Compare
Missed this one... and yep that's exactly what I need. Reworked the PR to just keep the tests and improve the docs. |
Jarod42
approved these changes
Sep 26, 2024
tritao
force-pushed
the
fix-table-merge
branch
from
4a76aa8 to
645f7b8
Compare
samsinsane
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixestable.mergefor array-based tables.Add tests and cross-link docs for table.merge/join.