Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with include failing to find embedded files #2272

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

samsinsane
Copy link
Member

What does this PR do?

Fixes issue with include failing to find embedded files when being called from an embedded file.

How does this PR change Premake's behavior?

Restores behaviour to before #2264.

Anything else we should know?

N/A

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@samsinsane
Copy link
Member Author

@Jarod42 can you let me know if issues persist with this change?

@Jarod42
Copy link
Contributor

Jarod42 commented Sep 29, 2024

@samsinsane : ok for me :-)

@samsinsane samsinsane merged commit 82317d6 into premake:master Sep 30, 2024
12 checks passed
@samsinsane samsinsane deleted the ssurtees/includeFix branch September 30, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants