Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces the
--curl-src
option which deprecates--no-curl
(for backwards compatibility), this new option allows users to pick between:none
, replaces--no-curl
contrib
, default and what is currently usedsystem
, the system libraryIn addition to this new option, the Linux builds will test all three options to ensure unit tests continue to work and don't have issues with the settings.
How does this PR change Premake's behavior?
Users can still build with
--no-curl
but it will warn and prompt users to migrate to--curl-src=none
.The core focus of this PR was to allow users to build Premake with their system curl instead.
Anything else we should know?
Various unit tests, specifically Nuget tests, weren't properly checking for the
http
. This check has been added so the builds continue to work.Did you check all the boxes?
closes #XXXX
in comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!