Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to use system curl #2275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samsinsane
Copy link
Member

What does this PR do?

This PR introduces the --curl-src option which deprecates --no-curl (for backwards compatibility), this new option allows users to pick between:

  • none, replaces --no-curl
  • contrib, default and what is currently used
  • system, the system library

In addition to this new option, the Linux builds will test all three options to ensure unit tests continue to work and don't have issues with the settings.

How does this PR change Premake's behavior?

Users can still build with --no-curl but it will warn and prompt users to migrate to --curl-src=none.

The core focus of this PR was to allow users to build Premake with their system curl instead.

Anything else we should know?

Various unit tests, specifically Nuget tests, weren't properly checking for the http. This check has been added so the builds continue to work.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@tritao
Copy link
Contributor

tritao commented Oct 3, 2024

@samsinsane
Copy link
Member Author

We may want to update the message from https://github.com/premake/premake-core/blob/master/modules/vstudio/vs2010_nuget.lua#L413 as well.

Good catch, I forgot to search the codebase for references to --no-curl.

@nickclark2016
Copy link
Member

This feels like a good idea to allow for usage of the host's curl.

@tritao
Copy link
Contributor

tritao commented Nov 11, 2024

Is this one ready to merge?

@Jarod42
Copy link
Contributor

Jarod42 commented Nov 11, 2024

@tritao : there is at least conflicts to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants