updated dotnetbase to generate configurations list in opening propert… #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ygroup containing project properties (fix for incorrect cofigurationmapping) (tests required)
Jarod42
reviewed
Nov 8, 2024
Comment on lines
97
to
99
| for prjcfg in project.eachconfig(prj) do | ||
| _p(3,'%s;',prjcfg.shortname) | ||
| end |
There was a problem hiding this comment.
Wonder if we can use something like table.implode(arr, "before", "after", "between") to avoid extra ';'.
There was a problem hiding this comment.
il give that a try now
There was a problem hiding this comment.
it worked but i can't figure out how to make it auto generate in the initial property group
Jarod42
reviewed
Nov 8, 2024
| -- | ||
| -- Write the available configurations to have correct configuration mapping on vs2022 format and later. | ||
| -- | ||
| function dotnetbase.projectConfigurations(prj) |
There was a problem hiding this comment.
That function is never called.
There was a problem hiding this comment.
i know, i don't kown where to put so it gets placed in the primary property group.
Jarod42
reviewed
Nov 9, 2024
| <OutputType>Exe</OutputType> | ||
| <AppDesignerFolder>Properties</AppDesignerFolder> | ||
| <TargetFramework>net8.0</TargetFramework> | ||
| <Configurations>Debug;Release</Configurations> |
There was a problem hiding this comment.
"Distribution" seems missing...
Jarod42
reviewed
Nov 9, 2024
|
|
||
| configurations { "Debug","Release","Distribution"} | ||
| test.capture [[ | ||
| <PropertyGroup> |
There was a problem hiding this comment.
From UT, indentation seems mismatching: check number of spaces or tab?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ygroup containing project properties
(fix for incorrect cofigurationmapping) (tests required)
What does this PR do?
Thanks for the contribution! Please provide a concise description of the problem this request solves.
this pr closes #2319
Are there any breaking changes? Will any existing behavior change?
Anything else we should know?
should documentation be changed to tell people about this because it is auto genrated from vs2022 onwards
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!