Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace MFC flag with a dedicated API #2334

Merged

Conversation

nickclark2016
Copy link
Member

@nickclark2016 nickclark2016 commented Nov 21, 2024

What does this PR do?

Replaces the MFC flag for a dedicated API, mfc.

How does this PR change Premake's behavior?

Deprecates MFC flag (warn) and will be removed after 5.0.0-beta4.

Anything else we should know?

Part of 5.0 release prep.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@nickclark2016 nickclark2016 requested a review from a team November 21, 2024 19:08
@nickclark2016 nickclark2016 force-pushed the feature/mfc-flag-replacement branch from ab56337 to 6d55c64 Compare November 22, 2024 05:33
src/_premake_init.lua Outdated Show resolved Hide resolved
website/docs/mfc.md Outdated Show resolved Hide resolved
@nickclark2016 nickclark2016 force-pushed the feature/mfc-flag-replacement branch from 6d55c64 to 578c4f3 Compare November 23, 2024 18:35
@nickclark2016 nickclark2016 requested a review from tritao November 23, 2024 18:36
@samsinsane samsinsane merged commit b4893c9 into premake:master Nov 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants