Increased consistency of p. usage #757
Conversation
There was a problem hiding this comment.
In theory, a harmless change. I thought we had removed the D module? LGTM, but I'll let @tvandijck have a quick look in case he has concerns with the size of the change.
| local p = premake | ||
| local project = p.project | ||
| local config = p.config | ||
| local d = p.modules.d |
There was a problem hiding this comment.
tab vs spaces... may want to check other files as well...
There was a problem hiding this comment.
The file was already using spaces, I feel like that change might be a bit unrelated to this PR. I'm happy to do up another PR if you'd like?
There was a problem hiding this comment.
OK... I think we should certainly make things consistent all around, according to the editorconfig file that is committed to the repository, and anyone committing to this repo should 100% use that tool in all their editors... so yeah, maybe a separate commit for that would be better.
|
Change looks harmless to me too... merge it ;) |
|
BTW... I'm pretty thankful you are willing to go through monkey work like this, so thank you very much. |
|
Haha, no worries! :) |
This is a pretty large change, but we went from ~900 usages of
premake.to ~175. I probably went a bit overboard, and I'm happy to remove the ones where I addedlocal p = premake.