Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in red. #815

Merged
merged 3 commits into from
Jun 18, 2017
Merged

Errors in red. #815

merged 3 commits into from
Jun 18, 2017

Conversation

tvandijck
Copy link
Contributor

I hard-coded the color to red here, otherwise we have to get it using all kinds of lua functions...
I just didn't think it was worth the effort...

this would work I think though:

lua_getglobal(L, "term");
lua_pushstring(L, "errorColor");
lua_gettable(L, -2);
int color = luaL_checknumber(L, -1);
lua_pop(L, 2);

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but do the colors need to be defined in lua scripts? The C functions could take the platform specific colors, while the Lua functions have Premake defined colors? Not really an issue since this currently only works on Windows, but would be good to figure out one day.

@tvandijck
Copy link
Contributor Author

well, we exposed the "infoColor" and "warningColor" in lua, so people can make their own picks.. I don't know if anyone ever will, but it's there because someone asked for that... so "errorColor" is there in lua, but since the error handling in C, it's currently not using it... I guess we could query it, just didn't seem worth the effort to me.

@tvandijck tvandijck merged commit 0f98798 into premake:master Jun 18, 2017
@tvandijck tvandijck deleted the errors-in-red branch June 18, 2017 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants