Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buildoutput pathvars #969

Merged
merged 2 commits into from
Dec 7, 2017

Conversation

tvandijck
Copy link
Contributor

It turns out, that Visual Studio really don't like having most of the pathVars in the <Outputs> property of a custom build command....

this just doesn't work. The command does the right thing, but the tracking of the outputs goes wrong, and visual studio manages to actually create a $(SolutionDir) folder on disk too.

    <CustomBuild Include="..\..\..\packages\tag_edit\include\tag_edit\tag_edit.tag">
      <FileType>Document</FileType>
      <Command>tagc --cpp --types --schema --out=$(SolutionDir)/generated_tag/tag_edit %(FullPath)</Command>
      <Outputs>$(SolutionDir)/generated_tag/tag_edit/tag_edit.h;$(SolutionDir)/generated_tag/tag_edit/tag_edit.cpp</Outputs>
      <Message>Compiling %(FullPath)</Message>
    </CustomBuild>

So instead of making pathVars the default for buildoutputs and buildinputs, we turn it off, and only turn it on through an override in the environment where appropriate.

@tvandijck tvandijck merged commit 056e539 into premake:master Dec 7, 2017
@tvandijck tvandijck deleted the fix-buildoutput-pathvars branch December 7, 2017 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants