Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues #43

Open
rporrasluc opened this issue Nov 21, 2018 · 4 comments
Open

Performance issues #43

rporrasluc opened this issue Nov 21, 2018 · 4 comments

Comments

@rporrasluc
Copy link

Hello, I spotted some performance issues in the middleware that can be really easily addressed. I am adding improvements as PRs, so I would really appreciate if they can be merged if they are ok. Any code change or improvement is welcome.

Thanks.

@rporrasluc
Copy link
Author

First PR is #42, just avoiding blacklist and/or whitelist checks once it is already known that the page should not be prerendered.

@rporrasluc
Copy link
Author

Second PR is #44. Please have a look to the PR description, I am specially concerned in so many calls to String#downcase method for any user agent that is not a bot (users for which the performance is really important).

@borisrorsvort
Copy link

@thoop Any chances you will be able to address those issues at some point ?
CleanShot 2021-06-28 at 09 53 12

@rporrasluc
Copy link
Author

Hello @borisrorsvort, I do not think such performance will be anyhow fixed by what I am suggesting. prerender middleware is usually slow because it needs to connect to prerender server, prerender server to get your web rendered and then give it back to the middleware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants