-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance issues #43
Comments
First PR is #42, just avoiding blacklist and/or whitelist checks once it is already known that the page should not be prerendered. |
Second PR is #44. Please have a look to the PR description, I am specially concerned in so many calls to |
@thoop Any chances you will be able to address those issues at some point ? |
Hello @borisrorsvort, I do not think such performance will be anyhow fixed by what I am suggesting. prerender middleware is usually slow because it needs to connect to prerender server, prerender server to get your web rendered and then give it back to the middleware. |
Hello, I spotted some performance issues in the middleware that can be really easily addressed. I am adding improvements as PRs, so I would really appreciate if they can be merged if they are ok. Any code change or improvement is welcome.
Thanks.
The text was updated successfully, but these errors were encountered: