Do not check blacklist/whitelist if is_requesting_prerendered_page is false #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great. I am not affiliated with this project, but we have merged your PR (along with some others) into our own fork here: https://github.com/ministrycentered/prerender_rails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to improve the performance of something as critical as a middleware, which is executed in every request.
According to the code, the blacklist and whitelist options are checked even if
is_requesting_prerendered_pagevariable is false. This does not make sense, since once this variable is false after the initial checks (no escaped_fragment, no crawler, no buffer agent) we know that the prerendered page will not be used.