Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes error when not using firestore #75

Merged
merged 1 commit into from
Dec 14, 2017
Merged

Fixes error when not using firestore #75

merged 1 commit into from
Dec 14, 2017

Conversation

qalqi
Copy link
Contributor

@qalqi qalqi commented Dec 12, 2017 •
edited
Loading

Description

Fixes error by proving right import incase of not using firestore

Check List

  • All test passed
  • Updated Any Relevant Docs

@codecov
Copy link

codecov bot commented Dec 12, 2017

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files           6        6           
  Lines         304      304           
  Branches       26       26           
=======================================
  Hits          294      294           
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac74f4...73ce5df. Read the comment docs.

@prescottprue prescottprue merged commit 12ebddf into prescottprue:master Dec 14, 2017
prescottprue added a commit that referenced this pull request Dec 14, 2017
@prescottprue
v2.0.0-beta.3
ee235d2 
* fix(component sub-generator): correct import statement when using
firestore - #75 - @qalqi
* fix(route sub-generator): reference correct component in route config
- #76 - @qalqi
@prescottprue prescottprue mentioned this pull request Dec 14, 2017
Merged
2 tasks
prescottprue added a commit that referenced this pull request Dec 14, 2017
@prescottprue
v2.0.0-beta.3
65dd65a 
* fix(component sub-generator): correct import statement when using firestore - #75 - @qalqi
* fix(route sub-generator): reference correct component in route config - #76 - @qalqi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qalqi @prescottprue