fix(Preset): Export users #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixes #218 |
Antonio-RiveroMartnez
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Preset, the Superset Users List view is disabled (since users are managed through Preset Manager). That said, in order to export users (with their local Superset IDs) we would parse the DOM of the Add DAR view.
There was a change to this view so that the users are not loaded to the DOM anymore -- instead, there's a user search field.
This PR updates the logic specifically for Preset Cloud to get the user information from the
/api/v1/chart/related/ownersfield (which lists all members with proper pagination).This is a temporary fix, as there's ongoing work to migrate the Superset Roles view to RESTful, and later do the same with Preset's DAR view.