Avoid copying Sexps that are too large #1820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1816, #1546, maybe others.
I avoided doing this in the past, because checking the size of the s-exps all the time seemed expensive. However, based on some testing, it has little to no impact on scan times. Caching the s-sexp mass doesn't make much of a difference.
On the other hand, it resolves some performance issues and doesn't appear to reduce useful results.
If needed, the mass limit can be adjusted by using a config file. Not adding a command line option at this time.