Add Sidebar Line Height #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dannylonglegs Let's review this on our call tomorrow. |
greatislander
requested changes
Aug 2, 2018
| /// Line Height for Sidebar on `<p>` elements that are children of elements with a class of `sidebar`. | ||
| /// @type String | ||
| /// /// @since 1.1.0 | ||
| $sidebar-line-height: 1.4em !default; |
There was a problem hiding this comment.
@dannylonglegs Was this inherited from somewhere else before? I'm concerned this might be a breaking change.
|
It may have been inherited from body but im not 100% sure. I will check.
…On Thu, Aug 2, 2018 at 11:20 AM, Ned Zimmerman ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In assets/styles/variables/_specials.scss
<#197 (comment)>:
> @@ -428,6 +428,11 @@ $sidebar-font-weight: normal !default;
/// @type String
$sidebar-align: left !default;
+/// Line Height for Sidebar on `<p>` elements that are children of elements with a class of `sidebar`.
+/// @type String
+/// /// @SInCE 1.1.0
+$sidebar-line-height: 1.4em !default;
@dannylonglegs <https://github.com/dannylonglegs> Was this inherited from
somewhere else before? I'm concerned this might be a breaking change.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#197 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUK4GiFcyE_nuoKpZ8jOKqcwXlpE-4H3ks5uMxilgaJpZM4VrLSr>
.
|
greatislander
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.