Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use text-sidebar width variable #329

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

beckej13820
Copy link
Contributor

@beckej13820 beckej13820 commented Jul 4, 2023

This change adds the variable $textbox-sidebar-max-width to the margin inside. This change should not impact existing themes because the default for the variable is 25% but should be checked. It would only effect a theme that has a value for $textbox-sidebar-max-width which would have previously done nothing.

Fix for #327

…n inside. This change should not impact existing themes because the default for the variable is 25% but should be checked. It would only effect a theme that has a value for $textbox-sidebar-max-width which would have previously done nothing.
Copy link
Member

@SteelWagstaff SteelWagstaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. $textbox-sidebar-max-width is already defined here:

$textbox-sidebar-max-width: 25% !default;
with a default value of 25% so this should work as expected. We only have one theme (Malala) which currently overrides this value and sets it higher (30%).

@SteelWagstaff SteelWagstaff merged commit 6ea3a86 into pressbooks:dev Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants