Merge pull request #884 from pressbooks/pb-876-parsing-error

ToC Toggle Button A11y Fix
pressbooks · Oct 29, 2021 · eb4c9d1 · eb4c9d1
2 parents 2942e93 + f2cb355
commit eb4c9d1
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 12 deletions.
diff --git a/assets/src/scripts/routes/home.js b/assets/src/scripts/routes/home.js
@@ -20,7 +20,7 @@ export default {
  )
  .prop( 'hidden', false );
  } );
- $target.parents( '.toc__toggle' ).attr( 'aria-expanded', 'true' );
+ $target.parents( '.toc__toggle' ).attr( 'data-expanded', 'true' );
  } );
 
  $( document.body ).on( 'click', '.toc__toggle #hide', function ( e ) {
@@ -36,7 +36,7 @@ export default {
  )
  .attr( 'hidden', 'true' );
  } );
- $target.parents( '.toc__toggle' ).attr( 'aria-expanded', 'false' );
+ $target.parents( '.toc__toggle' ).attr( 'data-expanded', 'false' );
  } );
  } );
  },

diff --git a/assets/src/styles/components/_toc.scss b/assets/src/styles/components/_toc.scss
@@ -132,19 +132,19 @@ $light: #eee;
  text-align: center;
 }
 
-.toc__toggle[aria-expanded="false"] #hide {
+.toc__toggle[data-expanded="false"] #hide {
  display: none;
 }
 
-.toc__toggle[aria-expanded="false"] #show {
+.toc__toggle[data-expanded="false"] #show {
  display: inline-block;
 }
 
-.toc__toggle[aria-expanded="true"] #hide {
+.toc__toggle[data-expanded="true"] #hide {
  display: inline-block;
 }
 
-.toc__toggle[aria-expanded="true"] #show {
+.toc__toggle[data-expanded="true"] #show {
  display: none;
 }
 

diff --git a/dist/mix-manifest.json b/dist/mix-manifest.json
@@ -1,9 +1,9 @@
 {
- "/scripts/book.js": "/scripts/book.js?id=e66e96b2f7d5e73debc8",
+ "/scripts/book.js": "/scripts/book.js?id=e9e6c9579c3aa2a2b5f7",
  "/scripts/pane.js": "/scripts/pane.js?id=7e5b385cb135973c79f7",
  "/scripts/collapse-sections.js": "/scripts/collapse-sections.js?id=b902d882dd21410b4387",
  "/scripts/lightbox.js": "/scripts/lightbox.js?id=cb2b7b2a5fb303c3095d",
- "/styles/book.css": "/styles/book.css?id=9a868437441809f4adb8",
+ "/styles/book.css": "/styles/book.css?id=c427332d12f4f3dab967",
  "/styles/web-house-style.css": "/styles/web-house-style.css?id=f2ec506de7eae2e9ddc5",
  "/scripts/sharer.js": "/scripts/sharer.js?id=726d50806d381e7cf7d0",
  "/scripts/lity.js": "/scripts/lity.js?id=b91ed0405760d2e124c1",

diff --git a/dist/scripts/book.js b/dist/scripts/book.js
diff --git a/dist/scripts/sharer.js b/dist/scripts/sharer.js