Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove image max-size for centered images in PDF exports #851

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

fdalcin
Copy link
Contributor

@fdalcin fdalcin commented Sep 1, 2021

Issue #850

This PR removes image adjustments on PDFs for centered aligned images (see).

How to test

  1. Import an image, and insert as "large" into a chapter.
  2. Set an alignment for center, left or right.
  3. Export as a PDF
  4. Left and right aligned images should have the sized adjusted. Centered images should remain untouched.

image

@fdalcin fdalcin requested a review from a team September 1, 2021 16:11
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #851 (3261344) into dev (f1dd339) will not change coverage.
The diff coverage is n/a.

❗ Current head 3261344 differs from pull request most recent head a9c0280. Consider uploading reports for the commit a9c0280 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #851   +/-   ##
=======================================
  Coverage   48.27%   48.27%           
=======================================
  Files           4        4           
  Lines         464      464           
=======================================
  Hits          224      224           
  Misses        240      240           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1dd339...a9c0280. Read the comment docs.

Copy link
Member

@SteelWagstaff SteelWagstaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteelWagstaff SteelWagstaff merged commit ed2af00 into dev Sep 1, 2021
@SteelWagstaff SteelWagstaff deleted the pbb-850-fix-centered-images branch September 1, 2021 16:27
@SteelWagstaff
Copy link
Member

Works as expected on integrations. Images which are center aligned or no alignment do not have a special max-width applied in exports. Images which are left or right aligned are set to max-width: 50% in export files.

@SteelWagstaff SteelWagstaff changed the title Adjust image size only for left and right aligned ones Remove image max-size for centered images in PDF exports Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants