Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for Gutenberg : cover image and other blocks #1601

Closed
ghost opened this issue Oct 7, 2018 · 8 comments · Fixed by #1628
Closed

support for Gutenberg : cover image and other blocks #1601

ghost opened this issue Oct 7, 2018 · 8 comments · Fixed by #1628

Comments

@ghost
Copy link

ghost commented Oct 7, 2018

@ghost ghost changed the title support for Gutenberg cover image support for Gutenberg : cover image and other blocks Oct 12, 2018
@ghost ghost assigned ghost and eri-trabiccolo Oct 12, 2018
@ghost
Copy link
Author

ghost commented Oct 18, 2018

will be done here presscustomizr/hueman#702

@eri-trabiccolo
Copy link
Collaborator

see also #1611 for blockquotes and pullquotes

eri-trabiccolo added a commit to eri-trabiccolo/customizr that referenced this issue Oct 26, 2018
@eri-trabiccolo
Copy link
Collaborator

reopening because of presscustomizr/hueman#702 (comment)

@eri-trabiccolo
Copy link
Collaborator

eri-trabiccolo commented Nov 15, 2018

According to https://richtabor.com/gutenberg-image-alignments/

these are the blocks that support new content alignments:

  • Pullquote Block

  • Gallery Block

  • Image Block

  • Cover Image Block

  • Video/Audio Block

  • Table Block

  • Columns Block

  • Text Columns Block

  • Categories Block (fullwidth only)

  • Embed Block

  • Media & Text

I'm going to see which and how to implement their alignment.

Edit:
As of now 15/11/2018:

  • no alignwide alignfull classes are added to the Pullquote Block (probably a Gutenberg bug), anyway I "emulated" the test by manually adding those classes.
  • couldn't find the Text Columns block, I guess it has been replaced by the Media & Text, that I've added to the list.
  • The Table block has been aligned with some additional JS at the moment in the cases:
    a) alignwide
    b) alignfull and alignwide in a boxed layout

@ghost
Copy link
Author

ghost commented Nov 15, 2018

OK Thank you.
Let's schedule a chat about this and select2 at around 2PM, what do you think ?

@eri-trabiccolo
Copy link
Collaborator

Fine for me, talk you later then!

@ghost
Copy link
Author

ghost commented Nov 15, 2018

https://weblines.com.au/gutenberg-blocks-wide-alignment-full-width/

What Block Types Can Be Full or Wide-Aligned?

Assuming that your theme supports them, the new alignment options are offered for these blocks:-

  • Cover Image Block
  • Image Block
  • Gallery Block
  • Pullquote Block
  • Video Block
  • Table Block
  • Columns Block
  • Categories Block (fullwidth only)
  • Embed Block

@eri-trabiccolo
Copy link
Collaborator

eri-trabiccolo commented Nov 15, 2018

see list of succesfully tested blocks with:
#1628
https://github.com/presscustomizr/customizr-front-js-parts/pull/43

at:
#1601 (comment)

eri-trabiccolo added a commit to eri-trabiccolo/customizr that referenced this issue Nov 15, 2018
eri-trabiccolo added a commit to eri-trabiccolo/customizr that referenced this issue Nov 16, 2018
@ghost ghost closed this as completed in #1628 Nov 16, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant