Fix several issues and refactor code to conform WPCS #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now they run properly as for single site, so for multisite. [FIXUP] Fix Travis with php 5.6. [FIXUP] Fix Redis port.
[FIXUP] Fixed bug in the code. [FIXUP] Fix WPCS in tests. [FIXUP] Add package.
When several installs do not define WP_CACHE_KEY_SALT, they used same cache keys, what produced multiple bugs on sites.
soulseekah
reviewed
Feb 21, 2020
| @@ -463,7 +463,7 @@ public function __construct( $redis_instance = null ) { | |||
| * multi single WP installs on the same server. | |||
| */ | |||
| if ( ! defined( 'WP_CACHE_KEY_SALT' ) ) { | |||
| define( 'WP_CACHE_KEY_SALT', '' ); | |||
| define( 'WP_CACHE_KEY_SALT', ABSPATH ); | |||
soulseekah
reviewed
Feb 21, 2020
| @@ -561,7 +561,7 @@ public function get( $_key, $group = 'default', $force = false ) { | |||
|
|
|||
| if ( isset( $this->to_unserialize[ $redis_key ] ) ) { | |||
| unset( $this->to_unserialize[ $redis_key ] ); | |||
| $value = unserialize( $value ); | |||
| $value = maybe_unserialize( $value ); | |||
There was a problem hiding this comment.
This can actually spawn more errors. Because unserialize returns an empty value and a warning that something is wrong, which is arguably safer and more predictable than what maybe_unserialize returns - the value itself which is unexpected.
Moved to #19
soulseekah
requested changes
Feb 21, 2020
|
Thank you for your contribution. We'll now close this PR as it greatly strays away from our contributing guidelines. We value your time. Please see https://github.com/pressjitsu/pj-object-cache-red/blob/master/CONTRIBUTING.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests.
Fix check that Redis class exists.
Fix warning that occurs in some scenarios.
Refactor code to conform WPCS.