Improve custom logger: Use stdlib's existing logger variable by default #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up on #105. Don't allocate new stdlib's logger and reuse the default logger (unexported) variable. This will enable people make custom changes to the std logger, ie. log.SetFlags(), log.SetPrefix() or log.SetOutput() without having to duplicate the same code and applying it to goose logger.
mfridman
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #105. Don't allocate new stdlib's logger and reuse
the default logger (unexported) variable. This will enable people
make custom changes to the std logger, ie. log.SetFlags(),
log.SetPrefix() or log.SetOutput() without having to duplicate
the same code and applying it to goose logger.
Note: I wish Go made the std logger an interface soon. They might plan it for Go 2, but who knows when it will land.. golang/go#13182