Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTC for timestamps when creating a migration #242

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

linux2647
Copy link
Contributor

So, I understand that there is prior art here (#38, #50, #63), but my team is using timestamped versions and switching to sequential numbering is not an option at this time. We're split across multiple timezones and in order to keep things a little more sane, UTC would be a welcome change for the timestamps. Maybe in the future we can migrate over to sequential, but this is where we are at.

@mfridman
Copy link
Collaborator

Are you compiling goose yourself or using the native goose with go get or go install?

@linux2647
Copy link
Contributor Author

Native goose with go install

@mfridman
Copy link
Collaborator

I'm worried this would cause issues for someone out there. Fwiw you can set TZ="UTC" goose ... ?

In a breaking /v4 we can set UTC as a default for timestamps.

@linux2647
Copy link
Contributor Author

linux2647 commented Oct 24, 2021 via email

@emma-46
Copy link

emma-46 commented May 9, 2022

With my team we are facing this exact same issue of having the timestamp utc specified, is there any news on this topic ? Thanks !

@mfridman
Copy link
Collaborator

This will be merged and released in v3.17.0 with a disclaimer ⚠️ that it's a potentially breaking change.

@mfridman mfridman merged commit c541882 into pressly:master Dec 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants