-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve bundle deprecations #317
Conversation
@J-Ben87 do you have an idea about how we could manage a smooth upgrade path with such change |
You mean the fact that the parameter is no longer nullable? Isn't this already handled by the dependency injection and the service definition we have control over? |
A parameter not being nullable anymore is not really an issue, because you can add a if to trigger deprecation |
src/Service/AbstractGenerator.php
Outdated
public function __construct( | ||
EventDispatcherInterface $dispatcher, | ||
int $itemsBySet = null, | ||
UrlGeneratorInterface $urlGenerator = null | ||
UrlGeneratorInterface $urlGenerator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That, or using non typed arguments and warning if their type is invalid.
|
src/Event/SitemapPopulateEvent.php
Outdated
*/ | ||
public function __construct( | ||
UrlContainerInterface $urlContainer, | ||
string $section = null, | ||
UrlGeneratorInterface $urlGenerator = null | ||
UrlGeneratorInterface $urlGenerator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, we also missed this one 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch
No description provided.