Use https for real URLs #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is indeed a good idea, I want to merge it |
yann-eugone
approved these changes
Feb 9, 2024
|
If people use full xml output fixtures with those links then it will break for them totally, I'm using like that by myself, but I don't mind to break them, it's easy to fix and it doesn't really break any functionality :) |
|
OK, so at least publish it in a minor version |
yann-eugone
added a commit
that referenced
this pull request
Mar 19, 2024
This reverts commit 4bc2aa2.
yann-eugone
added a commit
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.