Make RPresto compatible with new Presto JSON data format and dbplyr 2.5.0 #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #280 +/- ##
==========================================
- Coverage 34.27% 33.83% -0.44%
==========================================
Files 46 46
Lines 1777 1800 +23
==========================================
Hits 609 609
- Misses 1168 1191 +23 ☔ View full report in Codecov by Sentry. |
… with dbplyr 2.5.0.
…uoteIdentifier() doesn't have component names since 1.2.0
This was referenced Dec 12, 2024
willshen99
reviewed
Dec 12, 2024
Comment on lines
+34
to
+37
| if (inherits(name, "dbplyr_table_path")) { # dbplyr >= 2.5.0 | ||
| name <- dbplyr::table_path_name(name, con) | ||
| } else { | ||
| name <- DBI::dbQuoteIdentifier(con, name) |
There was a problem hiding this comment.
I think this is still breaking for dbplyr < 2.5.0 and DBI >= 1.2.0
There was a problem hiding this comment.
Can you be more specific about the breaking? I ran all the unit tests with dbplyr 2.4.0 and DBI 1.2.3 and all tests passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been some changes to Presto and
dbplyrwhich result in RPresto 1.4.6 having errors. This PR combines a few commits to solve those issues and make RPresto compatible again.This PR should fix #272, #274, and #277.