Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Open Telemetry Implementation in Presto #23975

Open
sureshbabu-areekara opened this issue Nov 7, 2024 · 3 comments
Open

Enhance Open Telemetry Implementation in Presto #23975

sureshbabu-areekara opened this issue Nov 7, 2024 · 3 comments

Comments

@sureshbabu-areekara
Copy link

sureshbabu-areekara commented Nov 7, 2024

Open Telemetry is a powerful serviceability framework which helps to gain insights into the performance and behaviour of the systems. It facilitates generation, collection, and management of telemetry data such as traces.

The OSS Presto already had a basic implementation of Open Telemetry #18534, which was an experimental feature, had a limited set of telemetry data (Query state changes) and did not include a child span concept.

This enhancement will make Presto more flexible, allowing support for both parent and child spans. Additionally, spans can now be propagated to the worker nodes as well.

@tdcmeehan
Copy link
Contributor

Please note that there is an SPI and engine integration and a plugin which integrates with OpenAPI. Can you describe the SPI and engine integration more thoroughly--for example, is there any change required to communicate span information in the worker back to the coordinator? Can you create an RFC for this design that outlines changes to the SPI, engine (communication for example of spans), and implementation of the Open Telemetry spec as a plugin?

@sureshbabu-areekara
Copy link
Author

sureshbabu-areekara commented Nov 8, 2024

Hi @tdcmeehan We have raised RFC prestodb/rfcs#33. Below is the proposed architecture.

image image

Please let me know if any more info required.

@tdcmeehan
Copy link
Contributor

@sureshbabu-areekara thank you, but this diagram does not answer my questions. I have left more detailed feedback on the RFC. Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants