RFC for Open Telemetry Implementation for Presto. #33
Conversation
sureshbabu-areekara
force-pushed
the
main
branch
from
d133671
to
8c51e68
Compare
RFC-0009-open-telemetry.md
Outdated
| span-sampling=true | ||
| ``` | ||
|
|
||
| ***otel-factory.name***: unique identifier for OpenTelemetry factory implementation to be registered |
There was a problem hiding this comment.
This seems to imply that the only tracing providers supported must implement the Open Telemetry spec. The runtime should have no knowledge of any aspect of the Open Telemetry spec. The Open Telemetry spec should be implemented as a plugin and the SPI integration with the runtime should have a generic concept of tracing without any knowledge of any particular spec.
As an example, the Presto runtime and execution engines do not have any knowledge of the Iceberg spec either. They communicate through the connector SPI.
Please update your proposal with specifics on the abstractions that will be used within the SPI to accomplish this richer tracing functionality. Thank you.
There was a problem hiding this comment.
Hi @tdcmeehan The abstraction in SPI is generic and can be implemented by any tracing providers. If the key with "otel" and "OpenTelemetry factory" in the description are confusing here we could modify to some generic name like "tracing-factory-name" and "factory".
There was a problem hiding this comment.
Please add details on the changes being made to the SPI in this document.
sureshbabu-areekara
force-pushed
the
main
branch
from
2a53277
to
286b13c
Compare
No description provided.