Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assertj in TestSignature.java #4405

Closed
losipiuk opened this issue Jan 22, 2016 · 1 comment
Closed

Use assertj in TestSignature.java #4405

losipiuk opened this issue Jan 22, 2016 · 1 comment

Comments

@losipiuk
Copy link
Contributor

Using assertj in presto would improve tests readability. Good place for start is TestSignature.java.

@arhimondr
Copy link
Member

We are going to refactor this as part of the DECIMAL PR.

arhimondr pushed a commit to Teradata/presto that referenced this issue Mar 14, 2016
As the signature parameters binging code has been moved to SignatureBinder,
all the parameters binding tests moved to the TestSignatureBinder class.

Assertions in TestSignatureBinder has been refactored in "assertj style".

This resolves prestodb#4405
arhimondr pushed a commit to Teradata/presto that referenced this issue Mar 22, 2016
As the signature parameters binging code has been moved to SignatureBinder,
all the parameters binding tests moved to the TestSignatureBinder class.

Assertions in TestSignatureBinder has been refactored in "assertj style".

This resolves prestodb#4405
arhimondr pushed a commit to Teradata/presto that referenced this issue Apr 4, 2016
As the signature parameters binging code has been moved to SignatureBinder,
all the parameters binding tests moved to the TestSignatureBinder class.

Assertions in TestSignatureBinder has been refactored in "assertj style".

This resolves prestodb#4405
arhimondr pushed a commit to Teradata/presto that referenced this issue Apr 18, 2016
As the signature parameters binging code has been moved to SignatureBinder,
all the parameters binding tests moved to the TestSignatureBinder class.

Assertions in TestSignatureBinder has been refactored in "assertj style".

This resolves prestodb#4405
arhimondr pushed a commit to Teradata/presto that referenced this issue Apr 25, 2016
As the signature parameters binging code has been moved to SignatureBinder,
all the parameters binding tests moved to the TestSignatureBinder class.

Assertions in TestSignatureBinder has been refactored in "assertj style".

This resolves prestodb#4405
arhimondr pushed a commit to Teradata/presto that referenced this issue Apr 28, 2016
As the signature parameters binging code has been moved to SignatureBinder,
all the parameters binding tests moved to the TestSignatureBinder class.

Assertions in TestSignatureBinder has been refactored in "assertj style".

This resolves prestodb#4405
@martint martint closed this as completed Apr 30, 2016
arhimondr pushed a commit to arhimondr/presto that referenced this issue May 1, 2016
As the signature parameters binging code has been moved to SignatureBinder,
all the parameters binding tests moved to the TestSignatureBinder class.

Assertions in TestSignatureBinder has been refactored in "assertj style".

This resolves prestodb#4405
martint pushed a commit to martint/presto-facebook that referenced this issue May 2, 2016
As the signature parameters binging code has been moved to SignatureBinder,
all the parameters binding tests moved to the TestSignatureBinder class.

Assertions in TestSignatureBinder has been refactored in "assertj style".

This resolves prestodb#4405
fiedukow pushed a commit to Teradata/presto that referenced this issue May 2, 2016
As the signature parameters binging code has been moved to SignatureBinder,
all the parameters binding tests moved to the TestSignatureBinder class.

Assertions in TestSignatureBinder has been refactored in "assertj style".

This resolves prestodb#4405

Conflicts:
	presto-spi/src/test/java/com/facebook/presto/spi/type/TestTypeSignature.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants