Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nimble] Rename a missed enum and a bit more #22577

Closed
wants to merge 0 commits into from

Conversation

helfman
Copy link

@helfman helfman commented Apr 19, 2024

Summary:
X-link: facebookincubator/velox#9549

Found some enums that were left behind during the rename.

Reviewed By: sdruzkin

Differential Revision: D56370309

@helfman helfman requested a review from a team as a code owner April 19, 2024 22:53
Copy link

linux-foundation-easycla bot commented Apr 19, 2024

CLA Not Signed

@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D56370309

helfman added a commit to helfman/presto that referenced this pull request Apr 21, 2024
Summary:
X-link: facebookincubator/nimble#30


X-link: facebookincubator/velox#9549

Found some enums that were left behind during the rename.

Reviewed By: sdruzkin

Differential Revision: D56370309
@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D56370309

helfman added a commit to helfman/presto that referenced this pull request Apr 22, 2024
Summary:
X-link: facebookincubator/nimble#30


X-link: facebookincubator/velox#9549

Found some enums that were left behind during the rename.

Reviewed By: sdruzkin

Differential Revision: D56370309
@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D56370309

helfman added a commit to helfman/presto that referenced this pull request Apr 24, 2024
Summary:
X-link: facebookincubator/nimble#30


X-link: facebookincubator/velox#9549

Found some enums that were left behind during the rename.

Reviewed By: sdruzkin

Differential Revision: D56370309
@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D56370309

helfman added a commit to helfman/presto that referenced this pull request Apr 24, 2024
Summary:
X-link: facebookincubator/nimble#30

Pull Request resolved: prestodb#22577

X-link: facebookincubator/velox#9549

Found some enums that were left behind during the rename.

Reviewed By: sdruzkin

Differential Revision: D56370309
helfman added a commit to helfman/presto that referenced this pull request Apr 24, 2024
Summary:
X-link: facebookincubator/nimble#30

Pull Request resolved: prestodb#22577

X-link: facebookincubator/velox#9549

Found some enums that were left behind during the rename.

Reviewed By: sdruzkin

Differential Revision: D56370309
@helfman helfman closed this Apr 24, 2024
facebook-github-bot pushed a commit to facebookincubator/nimble that referenced this pull request Apr 25, 2024
Summary:
Pull Request resolved: #30

X-link: prestodb/presto#22577

X-link: facebookincubator/velox#9549

Found some enums that were left behind during the rename.

Reviewed By: sdruzkin

Differential Revision: D56370309

fbshipit-source-id: 24b76bd948778091ec12bdbee9138f108be51b07
facebook-github-bot pushed a commit to facebookincubator/velox that referenced this pull request Apr 25, 2024
Summary:
X-link: facebookincubator/nimble#30

X-link: prestodb/presto#22577

Pull Request resolved: #9549

Found some enums that were left behind during the rename.

Reviewed By: sdruzkin

Differential Revision: D56370309

fbshipit-source-id: 24b76bd948778091ec12bdbee9138f108be51b07
Joe-Abraham pushed a commit to Joe-Abraham/velox that referenced this pull request Jun 7, 2024
Summary:
X-link: facebookincubator/nimble#30

X-link: prestodb/presto#22577

Pull Request resolved: facebookincubator#9549

Found some enums that were left behind during the rename.

Reviewed By: sdruzkin

Differential Revision: D56370309

fbshipit-source-id: 24b76bd948778091ec12bdbee9138f108be51b07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants