-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nimble] Rename a missed enum and a bit more #22577
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D56370309 |
helfman
added a commit
to helfman/presto
that referenced
this pull request
Apr 21, 2024
Summary: X-link: facebookincubator/nimble#30 X-link: facebookincubator/velox#9549 Found some enums that were left behind during the rename. Reviewed By: sdruzkin Differential Revision: D56370309
helfman
force-pushed
the
export-D56370309
branch
from
April 21, 2024 07:34
b1ea1ee
to
b384495
Compare
This pull request was exported from Phabricator. Differential Revision: D56370309 |
helfman
added a commit
to helfman/presto
that referenced
this pull request
Apr 22, 2024
Summary: X-link: facebookincubator/nimble#30 X-link: facebookincubator/velox#9549 Found some enums that were left behind during the rename. Reviewed By: sdruzkin Differential Revision: D56370309
helfman
force-pushed
the
export-D56370309
branch
from
April 22, 2024 16:04
b384495
to
a5fbef0
Compare
This pull request was exported from Phabricator. Differential Revision: D56370309 |
helfman
added a commit
to helfman/presto
that referenced
this pull request
Apr 24, 2024
Summary: X-link: facebookincubator/nimble#30 X-link: facebookincubator/velox#9549 Found some enums that were left behind during the rename. Reviewed By: sdruzkin Differential Revision: D56370309
helfman
force-pushed
the
export-D56370309
branch
from
April 24, 2024 07:31
a5fbef0
to
2bb67c5
Compare
This pull request was exported from Phabricator. Differential Revision: D56370309 |
helfman
added a commit
to helfman/presto
that referenced
this pull request
Apr 24, 2024
Summary: X-link: facebookincubator/nimble#30 Pull Request resolved: prestodb#22577 X-link: facebookincubator/velox#9549 Found some enums that were left behind during the rename. Reviewed By: sdruzkin Differential Revision: D56370309
helfman
force-pushed
the
export-D56370309
branch
from
April 24, 2024 19:38
2bb67c5
to
638edfb
Compare
helfman
added a commit
to helfman/presto
that referenced
this pull request
Apr 24, 2024
Summary: X-link: facebookincubator/nimble#30 Pull Request resolved: prestodb#22577 X-link: facebookincubator/velox#9549 Found some enums that were left behind during the rename. Reviewed By: sdruzkin Differential Revision: D56370309
helfman
force-pushed
the
export-D56370309
branch
from
April 24, 2024 20:49
638edfb
to
7cb94cc
Compare
helfman
force-pushed
the
export-D56370309
branch
from
April 24, 2024 21:12
7cb94cc
to
369f9d3
Compare
facebook-github-bot
pushed a commit
to facebookincubator/nimble
that referenced
this pull request
Apr 25, 2024
Summary: Pull Request resolved: #30 X-link: prestodb/presto#22577 X-link: facebookincubator/velox#9549 Found some enums that were left behind during the rename. Reviewed By: sdruzkin Differential Revision: D56370309 fbshipit-source-id: 24b76bd948778091ec12bdbee9138f108be51b07
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Apr 25, 2024
Summary: X-link: facebookincubator/nimble#30 X-link: prestodb/presto#22577 Pull Request resolved: #9549 Found some enums that were left behind during the rename. Reviewed By: sdruzkin Differential Revision: D56370309 fbshipit-source-id: 24b76bd948778091ec12bdbee9138f108be51b07
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: X-link: facebookincubator/nimble#30 X-link: prestodb/presto#22577 Pull Request resolved: facebookincubator#9549 Found some enums that were left behind during the rename. Reviewed By: sdruzkin Differential Revision: D56370309 fbshipit-source-id: 24b76bd948778091ec12bdbee9138f108be51b07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebookincubator/velox#9549
Found some enums that were left behind during the rename.
Reviewed By: sdruzkin
Differential Revision: D56370309